-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unknown contacts #32865
Merged
Merged
feat: unknown contacts #32865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
tapiarafael
force-pushed
the
feat/unknown-contacts
branch
from
September 3, 2024 14:55
2de6ef8
to
4e0a0bb
Compare
tapiarafael
force-pushed
the
feat/unknown-contacts
branch
from
September 3, 2024 16:03
4e0a0bb
to
838b7af
Compare
MarcosSpessatto
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth noting that these PRs don't contain changesets because the feature is not fully enabled yet; it's under a feature flag (test).
tassoevan
approved these changes
Sep 5, 2024
tassoevan
added
the
stat: QA assured
Means it has been tested and approved by a company insider
label
Sep 5, 2024
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Sep 5, 2024
KevLehman
requested changes
Sep 5, 2024
KevLehman
approved these changes
Sep 6, 2024
dionisio-bot
bot
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Sep 6, 2024
tapiarafael
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Sep 9, 2024
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
stat: QA assured
Means it has been tested and approved by a company insider
stat: ready to merge
PR tested and approved waiting for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Create an unknown contact every time a new visitor is created. If there's already a verified contact with the same email, just link the existent contact to the visitor
Issue(s)
Steps to test or reproduce
Further comments
SCI-47