Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unknown contacts #32865

Merged
merged 105 commits into from
Sep 9, 2024
Merged

feat: unknown contacts #32865

merged 105 commits into from
Sep 9, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Jul 23, 2024

Proposed changes (including videos or screenshots)

Create an unknown contact every time a new visitor is created. If there's already a verified contact with the same email, just link the existent contact to the visitor

Issue(s)

Steps to test or reproduce

Further comments

SCI-47

tapiarafael and others added 30 commits June 27, 2024 16:06
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
@tapiarafael tapiarafael marked this pull request as ready for review September 3, 2024 12:18
@tapiarafael tapiarafael requested review from a team as code owners September 3, 2024 12:18
@tapiarafael tapiarafael marked this pull request as draft September 3, 2024 12:19
Base automatically changed from feat/update-contact-endpoint to develop September 3, 2024 13:16
@tapiarafael tapiarafael marked this pull request as ready for review September 3, 2024 16:41
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that these PRs don't contain changesets because the feature is not fully enabled yet; it's under a feature flag (test).

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Sep 5, 2024
@tassoevan tassoevan added this to the 6.13 milestone Sep 5, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 5, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 6, 2024
@tapiarafael tapiarafael added the stat: ready to merge PR tested and approved waiting for merge label Sep 9, 2024
@kodiakhq kodiakhq bot merged commit 06dbf72 into develop Sep 9, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/unknown-contacts branch September 9, 2024 15:24
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants